-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make browser tests work again #21
Conversation
…wsers on Sauce Labs In case you want to revisit this in 5 years, my saucelab user account is 'jesperronn'
hmm, https://github.com/jesperronn/typeahead.js/commit/42aabc6d9a3c74773e8f7f1201b48f91e15da543 didn't work. The browser tests still don't run since Will put this PR in WIP until I'm satisfied. Feel free to help :) |
@jesperronn I think you might need to add
or
|
Hmm https://github.com/jesperronn/typeahead.js/commit/cddcbbe733ea2d8911873cece70c53662b2ae4e6 did not work either. From the Travis configuration I read that
Which means that this Pull request will never run the saucelabs tests. |
@jesperronn & @Apfeluser Due to the Travis environment var limitation on pull requests noted above, I suggest we just merge this PR and see what happens. It won't break anything in terms of actual functionality. |
@jlbooker & @corejavascript/collaborators Even though this were merged, my preliminary findings show me that I cannot even run these locally... perhaps some package inconsistency. I would love to solve #26 so that we can actually verify the tests locally (just for Phantom or Chrome). Preferably work on with this after a solution has been provided for #26 |
@jesperronn Thanks for the update! (Sorry for the late reply, didn't see the GH notification!) Moving this to the next milestone so we can get this release out the door. Let's continue working on this. |
We should really revive this before merging too many merge requests... |
Closing this as it has been open for ages. Feel free to reopen if you feel this is still relevant. |
Adding my Sauce Labs account with the hope to actually test in 11 browsers on Sauce Labs
I am uncertain if this is enough by itself, since the abandoned project had
credentials already (probably from @jharding)
Originally added to twitter/typeahead.js in July 2014
twitter/typeahead.js@f5af04b
In case you want to revisit this in 5 years, my saucelab user account is 'jesperronn'
When this PR works, it will fix #20